Skip to content

test(codex): stop two migration tests spawning the real codex CLI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenSheridanEdwards merged 1 commit into from
Aug 14, 2026
Merged

test(codex): stop two migration tests spawning the real codex CLI #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions tests/hermes_cli/test_codex_runtime_plugin_migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,16 @@ def test_full_migration_round_trip(self, tmp_path):
},
}
}
report = migrate(hermes_cfg, codex_home=tmp_path, expose_hermes_tools=False)
# discover_plugins=False: this test asserts config.toml rendering, not
# plugin discovery. Left at its default of True it spawns the real codex
# CLI, which runs `git ls-remote https://github.com/openai/plugins.git`
# — a live network call to a third-party repo, from a unit test.
report = migrate(
hermes_cfg,
codex_home=tmp_path,
discover_plugins=False,
expose_hermes_tools=False,
)
assert report.written
text = (tmp_path / "config.toml").read_text()
assert "[mcp_servers.filesystem]" in text
Expand Down Expand Up @@ -269,9 +278,11 @@ def test_preserves_user_mcp_server_outside_managed_block(self, tmp_path):


def test_summary_reports_migration_count(self, tmp_path):
# discover_plugins=False — see the note in the round-trip test above:
# the default spawns the real codex CLI and reaches the network.
report = migrate({
"mcp_servers": {"a": {"command": "x"}, "b": {"command": "y"}}
}, codex_home=tmp_path, expose_hermes_tools=False)
}, codex_home=tmp_path, discover_plugins=False, expose_hermes_tools=False)
summary = report.summary()
assert "Migrated 2 MCP server(s)" in summary
assert "- a" in summary
Expand Down
Loading