Skip to content

feat(webhook): route voice through the deliver-target platform adapter - #4

Closed
BenSheridanEdwards wants to merge 1 commit into
mainfrom
fix/webhook-voice-deliver
Closed

BenSheridanEdwards wants to merge 1 commit into
mainfrom
fix/webhook-voice-deliver

Conversation

@BenSheridanEdwards

Copy link
Copy Markdown
Owner

What

Formalizes the webhook voice hot-patch found running uncommitted on the live install (applied 2026-08-07, run.py.pre-jarvis-webhook-tts-20260807 backup). Webhook sessions that deliver elsewhere (e.g. deliver:telegram) now forward send_voice to the deliver target's adapter instead of degrading into a "Couldn't deliver the audio attachment" text.

Why

Fixes-via-PR-to-main rule: this code is live on the fleet but existed only as a dirty working tree on the install. This PR is byte-for-byte the running change.

Risk

None at runtime; already running since 2026-08-07. Merging just makes main match the install.

🤖 Generated with Claude Code

Webhook has no native audio transport; the base fallback degraded failed
voice sends into a 'Couldn't deliver the audio attachment' message on the
deliver:telegram path. Resolve the deliver target's adapter (including
per-profile adapters) and forward send_voice there, honoring deliver_extra
chat/thread ids and falling back to the platform home channel.

Hot-patched live on the install 2026-08-07 (pre-jarvis-webhook-tts backup);
this PR brings it under the fixes-via-PR-to-main rule.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@BenSheridanEdwards

Copy link
Copy Markdown
Owner Author

Superseded by #20 (fleet cut to v0.20.5).

This is an earlier, smaller version of the same fix: gateway/run.py + gateway/platforms/webhook.py, no tests, and without the _resolve_auto_tts_delivery helper. The fuller version merged as #6 (6b21ea9d6), which adds that helper plus 231 lines of tests in tests/gateway/test_webhook_voice_deliver.py.

#6 is carried into #20, rebased onto upstream's rewritten voice-dispatch block. Nothing here is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant