Fix running php artisan enum:annotate on long enum class
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially the preg_replace() method resulted in a PREG_JIT_STACKLIMIT_ERROR This change decreases the resources used on the test set as the comment row pattern is matched at once instead by the character. I used the https://regex101.com/ Regex Debugger to verify and visualize my findings.
|
@spawnia I have solved the issue by updating the used regex. |
|
Thanks @mikkoaf, I will prepare a release. |
spawnia
changed the title
php artisan enum:annotate on long enum class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests #293
Related Issue/Intent
Resolves #293
Changes
Currently adds a test depicting behavior described in the issue. Using the
php artisan enum:annotatecommand fails on a particular enumeration class.Breaking changes