Allow Description attribute on class #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* introduce new usage of Description attribute at class level * add new static method getClassDescription() on Enum * test new method getClassDescription()
spawnia
reviewed
Jul 1, 2022
spawnia
reviewed
Jul 1, 2022
|
@spawnia Thanks for your review 🙏 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
We are working with this package alongside Lighthouse.
As an updated our GQL standards we realized auto generated GQL enums from BenShampo\Enum does not generate a description for the enum, only its values.
This PR propose broadening the usage of the Description attribute, so that it may be used on the Enum class itself.
Next step will be to update the LaravelEnumType from Lighthouse to include the description on the generated enum 😄
Changes
Breaking changes
Nope.