Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with PHP 8.1 #233

Merged
merged 5 commits into from
Nov 16, 2021
Merged

Ensure compatibility with PHP 8.1 #233

merged 5 commits into from
Nov 16, 2021

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Nov 15, 2021

  • Added or updated tests
  • Added or updated the README.md
  • Detailed changes in the CHANGELOG.md unreleased section

Related Issue/Intent

Allows the library to be installed and used with PHP 8.1. I am currently getting the following error:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - bensampo/laravel-enum[v3.2.0, ..., v3.4.2] require laminas/laminas-code ^3.4 -![image](https://user-images.githubusercontent.com/12158000/141855849-53d89947-1ad7-4424-ae50-544cdfc372d4.png)satisfiable by laminas/laminas-code[3.4.0, 3.4.1, 3.5.0, 3.5.1].
    - bensampo/laravel-enum[v1.28.3, ..., v1.38.0] require php ~7.1 -> your php version (8.1.0-dev) does not satisfy that requirement.
    - bensampo/laravel-enum[v2.0.0, ..., v2.2.0] require php ^7.2.5 -> your php version (8.1.0-dev) does not satisfy that requirement.
    - bensampo/laravel-enum[v3.0.0, ..., v3.1.0] require php ^7.3 -> your php version (8.1.0-dev) does not satisfy that requirement.
    - laminas/laminas-code[3.4.0, ..., 3.4.1] require php ^7.1 -> your php version (8.1.0-dev) does not satisfy that requirement.
    - laminas/laminas-code[3.5.0, ..., 3.5.1] require php ^7.3 || ~8.0.0 -> your php version (8.1.0-dev) does not satisfy that requirement.
    - Root composer.json requires bensampo/laravel-enum ^1.28.3 || ^2 || ^3 -> satisfiable by bensampo/laravel-enum[v1.28.3, ..., v1.38.0, v2.0.0, v2.1.0, v2.2.0, v3.0.0, ..., v3.4.2].

#213 was a valid concern, but is no longer a problem.

image

Changes

Added

  • Allow package to be installed with PHP 8.1

Changed

  • Allow laminas/laminas-code:^4.0 as a dependency

Breaking changes

None

@spawnia spawnia changed the title Ensure compatibility with PHP 8 Ensure compatibility with PHP 8.1 Nov 16, 2021
@BenSampo BenSampo merged commit 6c73d70 into BenSampo:master Nov 16, 2021
@spawnia spawnia deleted the php-8.1-compatibility branch November 16, 2021 10:26
@spawnia
Copy link
Collaborator Author

spawnia commented Nov 16, 2021

Thanks for merging this PR, looking forward to a release 👍

@BenSampo
Copy link
Owner

Thanks for sorting this, it was on my list but you beat me to it :)

Released under 4.1.0:
https://github.com/BenSampo/laravel-enum/releases/tag/v4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants