Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the stubs path to laravel conventions + allow to publish stubs. #182

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Update the stubs path to laravel conventions + allow to publish stubs. #182

merged 2 commits into from
Oct 22, 2020

Conversation

Nevoss
Copy link
Contributor

@Nevoss Nevoss commented Oct 7, 2020 •
edited
Loading

  • Added or updated tests
  • Added or updated the README.md
  • Detailed changes in the CHANGELOG.md unreleased section

Related Issue/Intent

  • Change the path and names of the stubs to the Laravel framework conventions.
  • Allow users to publish the stubs and change them as they want.

Changes

  • In the make command, the path to the stubs now passes through the resolveStubPath method that checks if the stubs were published and then return the path to the stubs based on the result.
  • Allow users to publish the stubs.

Before I will update the readme and changelog files, let me know if this PR is intended to merge.

Thank you very much for this library. ❤️

@BenSampo
Copy link
Owner

BenSampo commented Oct 8, 2020

👍 Looks great thanks. Please update the readme and changelog then it's good to merge.

atymic
atymic approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@atymic atymic mentioned this pull request Oct 8, 2020
Closed
3 tasks
@Nevoss
Copy link
Contributor Author

Nevoss commented Oct 16, 2020

Hey @BenSampo,
Just update the README and CHANGELOG.

@BenSampo BenSampo merged commit 0e7bf48 into BenSampo:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atymic atymic atymic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nevoss @BenSampo @atymic