feat: provide trait to query flagged enums with Eloquent #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obennaci
force-pushed
the
query-flagged-enums
branch
from
70164a5
to
a467085
Compare
BenSampo
reviewed
Oct 8, 2020
BenSampo
reviewed
Oct 8, 2020
|
Hi @obennaci - this is looking really good, thanks for the time you've spent working on it. I've left a couple of comments, once you've addressed those it should be good to merge. |
|
@BenSampo suggestions applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
Resolves #155
Changes
Provide a trait to query flagged enums using Eloquent
Note
Still going through few details, and experimenting with potentialhasAllFlagsandhasAnyFlags