Localization order #141
Merged
Localization order #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenSampo Hey, what do you think about the merge? |
atymic
pushed a commit
to atymic/laravel-enum
that referenced
this pull request
Oct 11, 2020
* Update messages.php * Update EnumServiceProvider.php
bakerkretzmar
added a commit
to bakerkretzmar/laravel-enum
that referenced
this pull request
Sep 15, 2021
3 tasks
BenSampo
added a commit
that referenced
this pull request
Nov 9, 2021
* Revert #141 * Add tests * Update rules * Formatting * Update changelog Co-authored-by: Ben Sampson <[email protected]>
|
We need this merge when using nova |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
#134
Changes
Localization added by #134 make a little mess with translation file loading order.
Removing translation from ServiceProvider make back to track.