Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 small fixes for the thermostat status display #86

Merged
merged 2 commits into from
Feb 15, 2023
Merged

2 small fixes for the thermostat status display #86

merged 2 commits into from
Feb 15, 2023

Commits on Feb 9, 2023

  1. Fix "Heating Thermostat showing heating=on" when DomesticWater is hea… 

    …ting
    @rhammen
    rhammen authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    5744d73 View commit details
    Browse the repository at this point in the history

  2. Fix thermostat status display / make it consistent 

    The previously used status IN [LUX_STATUS_HEATING, LUX_STATUS_NO_REQUEST, LUX_STATUS_EVU] resulted in:
- the DomesticWater thermostat showing Idle while heatpump status = 'heating' 
but
- the heating thermostat showing as Off when the heatpump status = 'domestic water'

I think is better to make it more generic than to (try to) make the list complete. So I propose that:
1) Thermostat shows Off when the device is set to Off
2) Thermostat shows Heating (or Cooling) when the heatpump is used for the specific device .
3) Else, it will show Idle.
    @rhammen
    rhammen authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    9805dd8 View commit details
    Browse the repository at this point in the history