-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added time and day related evu events (related #38) #248 #249
Conversation
@BenPru can you help me please? |
@Gifford47 Sorry for the delay. |
The PR is not finalized. As I've wrote in the beginning, I have a issue with the correct datetime type. Can you please help me out? |
@Gifford47 I have the same issue and I'm pretty sure it originates from the attribute restoration as this always returns a datetime.
I did create a fix s-kurz@012baaf but I'm still testing it. I'm actually not entirely happy with my solution as I feel it would be better to instead rewrite the _restore_attr_value signature to provide the key as well |
Thx. You can check in line 456 with isinstance () if it's a list, then loop through it's elements. |
@Gifford47 Thx. I'll try that. I thought we had a string at this point |
@s-kurz any progress with the last commit? |
@Gifford47 I did adapt some parts and for me its running without issue now for 2 weeks |
i've added a new attribute
SA.EVU_DAYS
and a logic which saves the evu days into the mentioned attribute.in the
_calc_next_evu_event_minutes(self)
is now a new fraction of code which takes care of the days on which the evu is not present. it calculates the "pause" time and adds it toEVU_minutes_until_next_event
Knows Bug:
@BenPru currently i get the following error because of wrong types:
NOTE: i
ve changed
_attr_cache: dict[SA, object] = {}`