Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes/improvements #154

Merged
merged 25 commits into from
Oct 17, 2023
Merged

Conversation

rhammen
Copy link
Contributor

@rhammen rhammen commented Oct 15, 2023

  • add missing cooling sensors, incl. translations
  • fix correction calculation in heating thermostat
  • fix solar detection
  • fix cooling thermostat showing heating

custom_components/luxtronik/const.py Outdated Show resolved Hide resolved
LuxOperationMode.heating.value: HVACAction.HEATING.value,
LuxOperationMode.domestic_water.value: HVACAction.HEATING.value,
LuxOperationMode.domestic_water.value: HVACAction.IDLE.value,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When hot water is produced, the underfloor heating also receives heat.
So the heating thermostat is active if domestic_water is active.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I find this very strange.
Let's say we are in summer, and outside it is 20+ degrees.
Are you saying that when the heatpump heats the domestic hot water, the heating device is actually (also) heating your underfloor? And/or that it should show heating in that case?
That is not how my system works, and I think it would confuse a lot of users (to see the heating being turned on in summer)...
In my view, the luxtronik device is either heating, or domestic_water, or cooling. One action at a time.
That is also what the heatpump reports in its status line: There is no heatpump status "heating + domestic water", only "heating" or "hot water".

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The luxtronik firmware reports a lot of time not really the status what it is doing. See for example: OperationMode correction?

custom_components/luxtronik/number_entities_predefined.py Outdated Show resolved Hide resolved
custom_components/luxtronik/translations/de.json Outdated Show resolved Hide resolved
custom_components/luxtronik/translations/en.json Outdated Show resolved Hide resolved
custom_components/luxtronik/translations/de.json Outdated Show resolved Hide resolved
custom_components/luxtronik/translations/en.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rhammen rhammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved all remarks, with the exception of:

LuxOperationMode.domestic_water.value: HVACAction.IDLE.value,
versus
LuxOperationMode.domestic_water.value: HVACAction.HEATING.value,

In my view, the desired behavior of the integration is best reflected by using
HVAC_ACTION_MAPPING_HEAT:
LuxOperationMode.domestic_water.value: HVACAction.IDLE.value,

@rhammen rhammen requested a review from BenPru October 17, 2023 20:24
@BenPru
Copy link
Owner

BenPru commented Oct 17, 2023

In my view, the desired behavior of the integration is best reflected by using HVAC_ACTION_MAPPING_HEAT: LuxOperationMode.domestic_water.value: HVACAction.IDLE.value,

This behavior is okay for me. We can take it.
Just for fun you can have a look at the sensors of the underfloor heating (also in summer). In dhw working mode the underfloor heating gets also heated.

Copy link
Owner

@BenPru BenPru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work and your support.

@BenPru BenPru merged commit 93bbe24 into BenPru:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants