-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixes/improvements #154
Conversation
rhammen
commented
Oct 15, 2023
- add missing cooling sensors, incl. translations
- fix correction calculation in heating thermostat
- fix solar detection
- fix cooling thermostat showing heating
Add cooling sensor translations
Add cooling sensors translations
Add cooling sensors (still need correct translation)
…/BenPru_luxtronik into improve-Beta-integration
LuxOperationMode.heating.value: HVACAction.HEATING.value, | ||
LuxOperationMode.domestic_water.value: HVACAction.HEATING.value, | ||
LuxOperationMode.domestic_water.value: HVACAction.IDLE.value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When hot water is produced, the underfloor heating also receives heat.
So the heating thermostat is active if domestic_water is active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I find this very strange.
Let's say we are in summer, and outside it is 20+ degrees.
Are you saying that when the heatpump heats the domestic hot water, the heating device is actually (also) heating your underfloor? And/or that it should show heating in that case?
That is not how my system works, and I think it would confuse a lot of users (to see the heating being turned on in summer)...
In my view, the luxtronik device is either heating, or domestic_water, or cooling. One action at a time.
That is also what the heatpump reports in its status line: There is no heatpump status "heating + domestic water", only "heating" or "hot water".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The luxtronik firmware reports a lot of time not really the status what it is doing. See for example: OperationMode correction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have resolved all remarks, with the exception of:
LuxOperationMode.domestic_water.value: HVACAction.IDLE.value,
versus
LuxOperationMode.domestic_water.value: HVACAction.HEATING.value,
In my view, the desired behavior of the integration is best reflected by using
HVAC_ACTION_MAPPING_HEAT:
LuxOperationMode.domestic_water.value: HVACAction.IDLE.value,
This behavior is okay for me. We can take it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work and your support.