Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish this integration as ha core integrated module #75

Closed
9 of 13 tasks
BenPru opened this issue Jan 24, 2023 · 3 comments · Fixed by #140
Closed
9 of 13 tasks

Publish this integration as ha core integrated module #75

BenPru opened this issue Jan 24, 2023 · 3 comments · Fixed by #140
Assignees
Labels
enhancement New feature or request

Comments

@BenPru
Copy link
Owner

BenPru commented Jan 24, 2023

I'm currently trying to publish this integration as ha core integration.

Core draft

The first draft (first pull request) with only one platform "water_heater" is available here:
https://github.com/BenPru/core-1/tree/luxtronik2
The first draft with all platforms is available here:
https://github.com/BenPru/core-1/tree/luxtronik

Core draft all platforms - as custom component integration

The full integration with all platforms (but currently not the full functionality - not all sensors) as draft is available here:
https://github.com/BenPru/luxtronik/tree/core-preview

Todos:

  • discover over dhcp
  • add sensor: error_reason
  • add sensor: switchoff_reason
  • status sensor: add special case detection
  • domestic_water_thermal_desinfection_target attr: Last thermal desinfection
  • flow_out_temperature_target attr: Switch gap
  • test: sensor _restore_value
  • test: diag download
  • test: climate.heating
  • add: climate.cooling
  • english sensor names
  • add new binary sensor: id_web_asdin "ASD Abtauung wird beendet / Soledruck ausreichend"
  • add new binary sensor: ID_WEB_MOTin "Motorschutz OK"

Important notice
Yaml configuration with own defined sensors are no more supported.
Please use Bouni/Luxtronik for yaml configured sensors and ensure you don't have luxtronik2 yaml entries.

Changed sensors names:
climate._domestic_water --> water_heater._domestic_water
sensor._compressor_impulses --> sensor._compressor1_impulses

Improvements:

  • Direct update of the sensor values after writing a change to luxtronik.
  • Support for multiple heatpumps.
@BenPru
Copy link
Owner Author

BenPru commented Jan 25, 2023

@kbabioch I have created the first draft, but I have no tests.
This are the requirements:
https://developers.home-assistant.io/docs/development_testing/#writing-tests-for-integrations
Could you help me?

@kbabioch
Copy link

kbabioch commented Jan 25, 2023

Yes, happy to help. On the other hand I'm currently short on time. Not sure what your plan in regards to time is, but will definitely take me some time to have a detailed look here.

Anything specifically that you need to know or some special area where I should have a closer look?

@BenPru
Copy link
Owner Author

BenPru commented Jan 25, 2023

Anything specifically that you need to know or some special area where I should have a closer look?

You can review the prs:
home-assistant/core#86636
home-assistant/home-assistant.io#25949

I have created a very basicly test. Perhaps you can extend it:
https://github.com/BenPru/core-1/tree/luxtronik2/tests/components/luxtronik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants