Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coroutine 'LuxtronikThermostat._async_control_heating' was never awaited self._async_control_heating() #108

Open
augi opened this issue Jul 10, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@augi
Copy link
Contributor

augi commented Jul 10, 2023

This error originated from a custom integration.

Logger: py.warnings
Source: custom_components/luxtronik2/climate.py:254
Integration: Luxtronik
First occurred: June 30, 2023 at 7:02:03 PM (9 occurrences)
Last logged: July 9, 2023 at 9:29:18 PM

/config/custom_components/luxtronik2/climate.py:254: RuntimeWarning: coroutine 'LuxtronikThermostat._async_control_heating' was never awaited self._async_control_heating()

Maybe there should be something like asyncio.get_event_loop().run_in_executor() used. I'm using 2023.04.30.

@BenPru
Copy link
Owner

BenPru commented Sep 10, 2023

See the branch https://github.com/BenPru/luxtronik/tree/core-preview
I have redesigned the hole integration in this branch to publish it as core ha integration. But I have no support and atm not enough time to finalize the work on it.
See the issue #75.

@BenPru
Copy link
Owner

BenPru commented Oct 25, 2023

Unfortunately there is no new pypi python-luxtronik version yet.
In order to get and display the newly calculated values ​​immediately after a write process, a sleep of 1000ms is good. <800ms did not always deliver the new data.
However, sleep is prohibited in the HA core. An async would exit the thread and delay or make the GUI update impossible.
As a workaround, I'm simply considering closing the socket connection between write and read and re-establishing it. I guess this can make sleep unnecessary and we can still get the new data.

@BenPru BenPru added enhancement New feature or request help wanted Extra attention is needed labels Oct 25, 2023
@BenPru BenPru reopened this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants