Open
Conversation
NeVeSpl
added a commit
to NeVeSpl/NetArchTest.eNhancedEdition
that referenced
this pull request
May 13, 2023
Owner
|
I recognise that returning null is regarded as a bad habit, but I'm reluctant to introduce a breaking change to the public interface at this point. I'll keep this pull request open so it can be swept up when there's another major release - that will make it easier to signpost this kind of change so we don't break anybody's tests unnecessarily. |
Author
|
Fair enough, thx. |
|
I would really like this change because the first time I used this package I got a null reference exception because I expected failing types to be an empty array. I agree with @lkurzyniec that this is a common practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collections should never return
null. Better value for collection is just empty collection.As a reference, you can take API - collection endpoints never return
null, but empty array ([]).Null cause problems, ie I can't do like this
Assert.True(result.IsSuccessful, $"Failing Types: {string.Join("; ", result.FailingTypeNames)}");, I needAssert.True(result.IsSuccessful, $"Failing Types: {string.Join("; ", result.FailingTypeNames ?? Array.Empty<string>())}");(reference).