Skip to content

TrayIcon is correctly selected after startup #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2017

Conversation

patgrosse
Copy link
Contributor

The current audio device specific icon is used as tray icon after SoundSwitch is started and no switch has been performed

Copy link
Owner

@Belphemur Belphemur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check for
AppConfigs.Configuration.KeepSystrayIcon
in the initIcon method. If true, just return directly from the method.

@Belphemur Belphemur dismissed their stale review December 30, 2016 18:19

Redoing it

@@ -102,6 +103,19 @@ public void Dispose()
_updateMenuItem.Dispose();
}

private void InitIcon()
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check for
AppConfigs.Configuration.KeepSystrayIcon
in the initIcon method. If true, just return directly from the method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in commit 1808a5c

@Belphemur
Copy link
Owner

Great!
Thank you for this :)

@Belphemur Belphemur merged commit 85bf080 into Belphemur:master Jan 1, 2017
@patgrosse patgrosse deleted the fix_start_icon branch January 5, 2017 08:04
@Belphemur
Copy link
Owner

@all-contributors please add @patgrosse for code

@allcontributors
Copy link
Contributor

@Belphemur

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 1858

@Belphemur
Copy link
Owner

@all-contributors please add @patgrosse for code

@allcontributors
Copy link
Contributor

@Belphemur

I've put up a pull request to add @patgrosse! 🎉

@patgrosse
Copy link
Contributor Author

@Belphemur I'm flattered, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants