Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust enhancement of profile selection, toggling, rotation and no-hotkey profiles. #492

Closed
3 of 4 tasks
4girl1der opened this issue Aug 9, 2020 · 5 comments
Closed
3 of 4 tasks

Robust enhancement of profile selection, toggling, rotation and no-hotkey profiles. #492

4girl1der opened this issue Aug 9, 2020 · 5 comments
Labels
Enhancement Issue which are a enhancement

Comments

@4girl1der
Copy link

4girl1der commented Aug 9, 2020 •
edited by Belphemur
Loading

I would like to propose the following which would make this program really robust.
This addresses issue #420, #409 & #491 plus adds the one feature I would like see no-hotkey profiles with selection from taskbar icon..

To properly support this workflow would be:

  1. Under the settings Menu: # This works with profiles that have the available trigger of "Fast Rotation"

    1. Add the "ProfileRotateNext" and "ProfileRotatePrevious" hotkey assignments to this area.
    2. Add a option box to have "Double-click" taskbar icon to rotate profiles instead of output devices.

  2. Add the following "Available Triggers"

    1. "Fast Rotation" # This makes those profiles available to the "HotKey" rotation hotkey set under settings as well as the double click the taskbar icon option.
    2. "Taskbar Selection" # This makes those profiles show up in the list with the devices when you click the taskbar icon. Then a person can manually click the profile wanted to change both devices. Also lets people create profiles who don't want hotkeys.

If I new how to code better, I would help. :)
@4girl1der 4girl1der added the Enhancement Issue which are a enhancement label Aug 9, 2020
@Belphemur
Copy link
Owner

Hello,

I like most of the ideas presented here. I'll see what I can do.

@4girl1der
Copy link
Author

@Belphemur , Thank you, that is something I can donate too. :)

@Belphemur
Copy link
Owner

I haven't forgot about this.

I'm gonna implement it little by little. Right now, I'll add the profile to the menu when they have the "Taskbar Selection".

Belphemur added a commit that referenced this issue Apr 17, 2021
@Belphemur
feat(Profile::Trigger::TrayIcon): Add tray icon as trigger
4a43fa5 
The profile will be displayed in the toolstrip when left-clicking on the SoundSwitch tray icon.

See #492
@Belphemur Belphemur mentioned this issue Apr 17, 2021
Merged
@Belphemur
Copy link
Owner

Taskbar Selection is done.

You test it in the dev build:
https://nc.aaflalo.me/s/8DKytYCTAbrn6yz

github-actions bot pushed a commit that referenced this issue May 1, 2021
@semantic-release-bot
chore(release): 5.9.0 [skip ci]
1b3b44a 
## [5.9.0](v5.8.3...v5.9.0) (2021-05-01)

### Features

* **Profile::Trigger::TrayIcon:** Add tray icon as trigger ([4a43fa5](4a43fa5)), closes [#492](#492)

### Bug Fixes

* **Device:** Listing device causing application hanging ([55d7316](55d7316))
* **Notification::Windows:** Fix crash when using windows notification and mute microphone ([78053fb](78053fb)), closes [#596](#596)
* **Profile::Trigger:** Fix not calling the method in switch ([4b75a25](4b75a25))

### Enhancements

* **Profile:** Update the icon of the profile ([4cf5ab2](4cf5ab2))
* **Profile:** Update the icons for the Profile feature ([37b1f22](37b1f22))
* **Profile::Trigger:** Add new TrayMenu trigger to available triggers ([7d4e3d0](7d4e3d0))

### Languages

* **Croatian:** Translated Settings using Weblate ([3938217](3938217))
* **Hebrew:** Translated Settings using Weblate ([2a6c378](2a6c378))
* **Hebrew:** Translated Settings using Weblate ([58efe45](58efe45))
* **Korean:** Translated About using Weblate ([3aa5a12](3aa5a12))
* **Korean:** Translated Settings using Weblate ([5898dcb](5898dcb))
* **Korean:** Translated Settings using Weblate ([a9d70d3](a9d70d3))
* **Korean:** Translated Settings using Weblate ([77fe485](77fe485))
* **Korean:** Translated Settings using Weblate ([a8e3ec3](a8e3ec3))
* **Korean:** Translated Tray Icon using Weblate ([a66510b](a66510b))
* **Portuguese (Brazil):** Translated Settings using Weblate ([e11acfd](e11acfd))
* **Turkish:** Add language to the application ([6d3c40c](6d3c40c)), closes [#588](#588)
* **Turkish:** Translated About using Weblate ([d13a888](d13a888))
* **Turkish:** Translated About using Weblate ([f752680](f752680))
* **Turkish:** Translated Settings using Weblate ([ff0098d](ff0098d))
* **Turkish:** Translated Settings using Weblate ([fd4014d](fd4014d))
* **Turkish:** Translated Settings using Weblate ([ff2685b](ff2685b))
* **Turkish:** Translated Tray Icon using Weblate ([1f83dc6](1f83dc6))
* **Turkish:** Translated Update Download using Weblate ([f1de471](f1de471))
* **Turkish:** Translated Update Download using Weblate ([9ce1bfe](9ce1bfe))
@Belphemur Belphemur mentioned this issue May 2, 2021
Closed
@Belphemur
Copy link
Owner

With version v6.1.0, you'll be able to switch between using the same hotkey.

At this point, I've implemented most of the feature that was requested, I'm closing this issue :)

Explanation

#738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Issue which are a enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Belphemur @4girl1der