Skip to content

Install / Upgrade issue #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephen147 opened this issue Feb 6, 2020 · 6 comments
Closed

Install / Upgrade issue #404

stephen147 opened this issue Feb 6, 2020 · 6 comments
Labels
Bug Issues which are bug reports Comp-Installer Issues related to the installer

Comments

@stephen147
Copy link

Here's my issue that pops up when I go to install or upgrade the version.

This issue goes away when I run the installer as an admin (which I don't like doing)

image

Also here my zipped folder: %AppData%\SoundSwitch

SoundSwitch.zip

@Belphemur
Copy link
Owner

Belphemur commented Feb 6, 2020 via email

@stephen147
Copy link
Author

Hi,

I got this error when I tried it on a fresh install also and I choose only install for me (Single user).

Here's the installer I'm using: SoundSwitch_v5.0.1.14646_Release_Installer.exe

My OS details are: Version: 1909

image

@Belphemur
Copy link
Owner

Belphemur commented Feb 6, 2020 via email

@Belphemur Belphemur added Bug Issues which are bug reports Comp-Installer Issues related to the installer labels Feb 7, 2020
@Belphemur
Copy link
Owner

Will be fixed in a next release.
Thanks again for the bug report !

@snakecase
Copy link

It seems this problem still exists (just updated :P) for autoupdating C;\ProgramFiles installations which brings a question to my mind: what's the problem with setting requestedExecutionLevel to requireAdministrator in the app's manifest or at least replacing Skip this file (not recommended) button in OP (since it's not an option in a real world) button with Run as Administrator which just re-executes the downloaded installer? Or even better, make a check for permissions to the app's installed location before executing the downloaded installer and bring a dialog to run as Administrator if it is required. Those users who want to install the app into elevated locations will have no problem granting them to the installer and those who don't want to compromise their security will seamlessly install it into their user's folder as usual.

It will also be cool to add the same permissions check to the installer itself for first-time installations so new users won't have to cease the whole process after encountering the error in OP just to run the installer as Administrator from context menu again.

@Belphemur
Copy link
Owner

@snakecase Created an issue for it.

I should be able to make the updater detect how is soundswitch installed and run the installer in the right mode.

Belphemur added a commit that referenced this issue Apr 5, 2020
This way, it can choose how to launch the installer depending how the user has installed SoundSwitch.

For now, this only work for people that let it be installed in ProgramFile to detect if it's installed for all user instead of current user.

Fixes #416
See #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues which are bug reports Comp-Installer Issues related to the installer
Projects
None yet
Development

No branches or pull requests

3 participants