Updater Progress bar crash with Classic Visual Theme

[Belphemur]

SoundSwitch-crashlog-31_5_2017.zip

Message: Visual Styles-related operation resulted in an error because no visual style is currently active.
Source: System.Windows.Forms
StackTrace:
   at System.Windows.Forms.VisualStyles.VisualStyleRenderer.IsCombinationDefined(String className, Int32 part)
   at System.Windows.Forms.VisualStyles.VisualStyleRenderer..ctor(String className, Int32 part, Int32 state)
   at System.Windows.Forms.ProgressBarRenderer.InitializeRenderer(VisualStyleElement element)
   at System.Windows.Forms.ProgressBarRenderer.DrawHorizontalBar(Graphics g, Rectangle bounds)
   at SoundSwitch.UI.UserControls.TextProgressBar.OnPaint(PaintEventArgs e) in D:\VS\SoundSwitch\SoundSwitch.UI.UserControls\TextProgressBar.cs:line 48
   at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
   at System.Windows.Forms.Control.WmPaint(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

[FireEmerald]

At least a description about this crash would be helpful.
SoundSwitch Version?
When does it occur?
How to reproduce?
...

[Belphemur]

Sorry, done it fast this morning.

It's linked to using the Classic Theme on Windows 7.
The updater window crash (the progress bar on it to be exact). I had that problem before with another form.

The problem is linked directly with the fact there is no visual style when the classic mode is activated:

https://msdn.microsoft.com/en-us/library/system.windows.forms.progressbarrenderer(v=vs.110).aspx

The fix would be to check IsSupported: https://msdn.microsoft.com/en-us/library/system.windows.forms.progressbarrenderer.issupported%28v=vs.110%29.aspx?f=255&MSPPError=-2147217396

In the case it's not supported, just update the text and not the progress bar.

[FireEmerald]

The problem can't occur on Windows 10 Anniversary Update due to the fact that it seems like they removed the classic theme - i will need a virtual machine to reproduce this crash.

[Belphemur]

What annoys me is to know how old this issue really is ... But well, I should have checked the documentation before using this progress bar.

I added this progress bar in the beginning of the version 3.x.

[FireEmerald]

Think the worse bug is the exception handling at this place.

[Belphemur]

Holy Shit ... make sense ... it crashs at each "painting" of the progress bar ... Well clearly disable the painting if the theme is not supported.

…

On 2017-05-31 10:28 AM, FireEmerald wrote: 2017-05-31 16_26_11 <https://cloud.githubusercontent.com/assets/1107939/26636745/f81c61c4-461d-11e7-806e-851cdf35075e.png> Think the worse bug is the exception handling at this place. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#194 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMEsvjzyM-6aG0TBk2bTV5TSmcw6Q4Wks5r_XkUgaJpZM4NriIT>.

[FireEmerald]

Is there anything special when compiling SoundSwitch for older WinVersions, like Win7? I only get a APPCRASH after starting the *.exe if i use my compiled version.

I thought it would be enought to install the Visual C++ 2015 Build Tools.

[Belphemur]

Use the Make.bat to build the project. It will generate everything correctly.

It's easier to use the installer on the VM to try it out.

[FireEmerald]

Fixed in aa48697.

[Belphemur]

Can you do a pull request on dev ?

In the message put "Fixes #194", I'll merge it :)