Skip to content

ci: onboard multi-vendor AI PR review (OST-626 canary) - #1

Closed
BeliyDym wants to merge 1 commit into
mainfrom
feat/ai-review-onboarding
Closed

ci: onboard multi-vendor AI PR review (OST-626 canary)#1
BeliyDym wants to merge 1 commit into
mainfrom
feat/ai-review-onboarding

Conversation

@BeliyDym

@BeliyDym BeliyDym commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

OST-626 Packet 2 canary: onboard hermes-agent onto the three-lineage AI
PR-review setup that the rest of the BeliyDym fleet will inherit (Packet 3).

  • .github/workflows/ai-review.yml — thin caller of the reusable Claude
    reviewer at BeliyDym/.github/.github/workflows/ai-review.yml@v1
    (on: pull_request [opened, reopened, synchronize],
    enforce_bugfix_ledger: false).
  • .gemini/config.yaml + .gemini/styleguide.md — Gemini Code Assist config
    and review criteria tuned to this Python agent stack (supply-chain pinning /
    uv.lock gate, ruff PLW1514 encoding rule, provider-credential handling,
    async correctness, pytest integration-marker discipline).

Three independent reviewers per PR: Gemini Code Assist (App) + Claude
(this reusable workflow) + GitHub Copilot (App). The OpenAI Codex connector
is intentionally not part of the setup.

Canary acceptance criteria (this PR is the test)

  • Gemini Code Assist posts a review.
  • Claude reusable workflow runs and posts a review (requires the
    ANTHROPIC_API_KEY repo secret — fails closed to HIGH +
    needs-human-review if absent, by design).
  • GitHub Copilot posts a review.
  • No OpenAI Codex connector review (connector should be removed from this
    repo).

Test plan

  • Confirm the AI Review workflow run appears under Actions for this PR.
  • Confirm each of the three lenses left a review/comment.
  • If the Claude lens fails closed on a missing secret, add
    ANTHROPIC_API_KEY (SJ-owned) and re-run.

Add the three-lineage AI PR-review setup that every active BeliyDym repo
inherits:

- .github/workflows/ai-review.yml — thin caller of the reusable Claude
  reviewer at BeliyDym/.github@v1; on: pull_request [opened, reopened,
  synchronize]; enforce_bugfix_ledger: false (no BUGFIXES.md convention
  here); needs the ANTHROPIC_API_KEY repo secret.
- .gemini/config.yaml — Gemini Code Assist review config, ignore_patterns
  tuned for this repo (docs, locales, assets, lockfiles).
- .gemini/styleguide.md — review criteria tuned to the Python agent stack:
  exact-pin/uv.lock supply-chain gate, ruff PLW1514 encoding rule, provider
  credential handling, async correctness, pytest integration-marker
  discipline.

Claude lens (this workflow) + Gemini Code Assist (App) + GitHub Copilot
(App). Codex connector intentionally not part of the setup.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

hermes-agent (self-improving multi-provider AI agent, Python) AI Review (Updated)

Risk Level: HIGH
Summary: AI review skipped - ANTHROPIC_API_KEY not configured for this repo


Updated at 2026-06-03T08:41:50.323Z

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

🔎 Lint report: feat/ai-review-onboarding vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9056 on HEAD, 9056 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4788 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 618747e56a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


jobs:
ai-review:
uses: BeliyDym/.github/.github/workflows/ai-review.yml@v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin the reusable workflow to an immutable SHA

The new workflow executes BeliyDym/.github by the mutable @v1 ref while granting pull-requests: write, issues: write, and passing ANTHROPIC_API_KEY, so moving or hijacking that tag changes code this repo runs with write permissions and a secret. The repo's dependency policy requires GitHub Actions and reusable workflows to be pinned to a commit SHA with a version comment; use the current 40-character commit for v1 instead of the tag.

Useful? React with 👍 / 👎.

@BeliyDym

BeliyDym commented Jun 3, 2026

Copy link
Copy Markdown
Owner Author

Closing — not merging. This internal-to-fork PR (base/head both BeliyDym/hermes-agent, isCrossRepository=false, so no upstream-leak surface) was opened during the initial canary attempt before IRON Council 3/3 re-pointed the Packet 2 canary to an independent repo (ovu-app, now PR NousResearch#20).

Per the council decision (audits/ost626-fork-canary-scope/consensus.md), the 3 BeliyDym forks (hermes-agent, agent-orchestrator, GeoAgent) join the fleet in Packet 3 under a hardened internal-only contract: owner-gate if: github.repository_owner == 'BeliyDym' on the caller workflow + PR creation always --repo BeliyDym/<repo> + the same @v1 pin / fail-closed / secret-redaction guarantees. The artifacts on this branch predate that hardening, so this PR is superseded.

The branch feat/ai-review-onboarding is left in place; Packet 3 will re-onboard hermes-agent with the owner-gate added. No action needed here.

@BeliyDym BeliyDym closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant