This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Add test on ability to check json payload against json schema #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
link to #90 |
gmorel
changed the title
gmorel
force-pushed
the
fix/allow_schema_deep_validation
branch
from
ec35992
to
3938b76
Compare
gmorel
changed the title
|
ping @sanpii |
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| class Json | |||
| { | |||
| private $content; | |||
| protected $content; | |||
There was a problem hiding this comment.
This modification has no relation with the rest of this PR.
|
This has been applied as 68b0e36 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Currently when we use
@Then the JSON should be valid according to this schema:step, the JSON payload is not validated against the given schema.Here is the test highlighting the issue with the fix.
Keep up the good work