This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Handle file uploads correct #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 27, 2019 00:34
|
It has been 6 months now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you specify a file to be uploaded, that file is treated as the temporary upload file normally created by php. That is wrong behaviour, since that temporary file is usually moved or removed by the php application under test. So the next time you run the behat test the file that you used for the upload is not there anymore.
This is a PR to fix this. This PR also removes the temporary files it created afterwards if the application has not removed them.