Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds zScan method to Mock #112

Merged
merged 3 commits into from
May 2, 2023
Merged

Adds zScan method to Mock #112

merged 3 commits into from
May 2, 2023

Conversation

robertmarney
Copy link
Contributor

Adds zScan method to Mock

@robertmarney robertmarney requested a review from a team as a code owner March 26, 2023 13:58
thirsch
thirsch reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@thirsch thirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, would also appreciate to get the support soon. Just two small code style comments.

src/M6Web/Component/RedisMock/RedisMock.php Outdated Show resolved Hide resolved
tests/units/RedisMock.php Outdated Show resolved Hide resolved
@robertmarney robertmarney requested a review from thirsch May 2, 2023 14:21
@thirsch
Copy link
Contributor

thirsch commented May 2, 2023

Thanks, unfortunately, it's not enough to get my approve :D

@Oliboy50 Oliboy50 merged commit fdef627 into BedrockStreaming:master May 2, 2023
@Oliboy50
Copy link
Member

Oliboy50 commented May 2, 2023

Thank you (both) for your time.
It has been released in v5.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oliboy50 Oliboy50 Oliboy50 approved these changes

@thirsch thirsch thirsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmarney @thirsch @Oliboy50