Add variadic param name #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shavounet
approved these changes
Mar 3, 2023
Fabex
approved these changes
Mar 4, 2023
|
@codepluswander did you try this PR in your project and/or are you confident enough about it, so that we can merge and bump a new release? |
|
This PR resolves the issue #109 I had created. I tried this fix on my project and didn't find any issues so far |
|
Thank you for the PR, it has been released in v5.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In predis tag v2.1.2, the method signature of pipeline changed to contain a variadic argument, thus the mock generates an incompatible method signature. This just adds the
...if the argument is variadic.