Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix linux libc issues #921

Merged
merged 9 commits into from
Apr 20, 2023
Merged

build: fix linux libc issues #921

merged 9 commits into from
Apr 20, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Apr 19, 2023

Description

Fix linux libc issues by dynamically linking, and by building against an old version of libc.

Makes linux builds run inside a container where we can control the base image. We use Ubuntu 18.04 as this is the earliest version that we can (easily) run docker buildx on.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe force-pushed the build/fix-linux-builds branch from 438d6ab to 067cd54 Compare April 19, 2023 16:47
@didroe didroe marked this pull request as ready for review April 20, 2023 08:50
@didroe didroe changed the title build: fix linux builds build: fix linux libc issues Apr 20, 2023
@didroe didroe requested a review from cfabianski April 20, 2023 08:51
@didroe didroe merged commit 2988a87 into main Apr 20, 2023
@didroe didroe deleted the build/fix-linux-builds branch April 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants