Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sequence instead of list in init_beanie #1015

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Use sequence instead of list in init_beanie #1015

merged 1 commit into from
Sep 30, 2024

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Sep 4, 2024 •
edited
Loading

Riverfount
Riverfount previously approved these changes Sep 4, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LawMixer
LawMixer previously approved these changes Sep 4, 2024
View reviewed changes
Copy link

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@07pepa 07pepa dismissed stale reviews from LawMixer and Riverfount via 57e6bba September 14, 2024 12:27
adeelsohailahmed
adeelsohailahmed approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the typing_extensions.

It implicitly uses get_origin & get_args from typing module for Python versions 3.10 and above. So, indeed, this should work same as before. Good work!

Riverfount
Riverfount approved these changes Sep 18, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok to me.

@07pepa
Copy link
Member Author

07pepa commented Sep 19, 2024

I've checked the typing_extensions.

It implicitly uses get_origin & get_args from typing module for Python versions 3.10 and above. So, indeed, this should work same as before. Good work!

yes typing extension are just basicly compatible backports for types of future versions almost as pollyfill code for js

@07pepa 07pepa requested a review from mg3146 September 24, 2024 13:25
@07pepa 07pepa merged commit 5110b08 into BeanieODM:main Sep 30, 2024
19 checks passed
@07pepa 07pepa deleted the fix-#911 branch September 30, 2024 06:51
@staticxterm staticxterm mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LawMixer LawMixer LawMixer approved these changes

@adeelsohailahmed adeelsohailahmed adeelsohailahmed approved these changes

@Riverfount Riverfount Riverfount approved these changes

@mg3146 mg3146 Awaiting requested review from mg3146

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@07pepa @mg3146 @Riverfount @adeelsohailahmed @LawMixer