fresh view#4

Closed

ronso0 wants to merge 2 commits intoBe-ing:deere_stacked_waveforms_reworkfrom

ronso0:deere-rework-2.1

ronso0 commented Feb 8, 2017

No description provided.

ronso0 added 2 commits

February 9, 2017 00:41


          fresh view: smaller EQ knobs

354497c


          fresh view: Pitch container rearranged

fd344c9

Owner

Be-ing commented Feb 9, 2017

Looks like the aspect ratio of the knobs got skewed. They look stretched vertically. Also, the outer rings around the knobs are not showing.

Author

ronso0 commented Feb 9, 2017 via email

Yes, I removed the rings, this could save 20px of vertical space while they are still useful. What are the rings good for anyway? The small knobs I can fix the knobs' appearance, but the question is: doy you like the general idea? Do you like how BPM controls are arranged in normal deck mode?

On 09.02.2017 04:21, Be wrote: Looks like the aspect ratio of the knobs got skewed. They look stretched vertically. Also, the outer rings around the knobs are not showing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFqMd2ri1XNbLPBCqHJ4MQG2F4mJrq2zks5raoY6gaJpZM4L7hSs>.

Owner

Be-ing commented Feb 9, 2017 •

edited

Loading

I like the idea of shrinking the knobs. They are the limiting factor for the vertical height of the decks + mixer. I do not know if I like removing the outer rings. Shrinking the knobs without the outer rings might look better if the knobs are made circular again.

Do you like how BPM controls are arranged in normal deck mode?

Not really. I don't like how controls for BPM, key, and beatgrid are hidden behind clicks. That is a big discoverability issue. I didn't know those existed for a long time. However, I don't really want to put in the work to design a better way for Deere right now. If you'd like to try that, awesome. Please open a different PR for that though. I'd like to keep each PR small and focused.

Author

ronso0 commented Feb 9, 2017 via email

Not really. I don't like how controls for BPM, key, and beatgrid are

hidden behind clicks. I only refered to Sync, *+*, *-* and Rate display (my 2nd commit in the PR) There, I didn't change the functionality at all, just the arrangement. Beatgrid and Key buttons is another issue...

Owner

Be-ing commented Feb 9, 2017

I only refered to Sync, +, - and Rate display (my 2nd commit in the PR) There, I didn't change the functionality at all, just the arrangement.

Oh, yes, I do like that.

Author

ronso0 commented Feb 9, 2017

Can you reject the 1st commit about EQ knobs or should I a start a new for Sync stuff only?

Author

ronso0 commented Feb 9, 2017

I'll just close this PR and start a new one for Sync button etc.
Need to learn about cherry-pick and stuff..

ronso0 closed this

ronso0 deleted the deere-rework-2.1 branch

February 9, 2017 18:20

Be-ing pushed a commit that referenced this pull request


          Merge pull request #4 from daschuer/libraryFocus

c028f29

Library focus

Be-ing pushed a commit that referenced this pull request


          Merge pull request #4 from Be-ing/effects_refactoring

94c3b71

fix effect unloading

Be-ing pushed a commit that referenced this pull request


          Merge pull request #4 from ehendrikd/serato-markers-integration-cues-…

6f8da17

…coreaudio

CoreAudio MP3 offsets for Serato cues

Be-ing pushed a commit that referenced this pull request


          Merge pull request #4 from dj3730/ddj400

25b4581

Ddj400

Be-ing pushed a commit that referenced this pull request


          Merge pull request #4 from ronso0/search-clear-fix

9ab695e

Search clear fix

Be-ing pushed a commit that referenced this pull request


          EngineBuffer: Fix assert when new track is loaded during playback wit…

9614a8f

…h sync

When loading a track that is not yet present in the library (and thus
doesn't have any BPM because it hasn't been analyzed yet) while another
deck is playing and both decks have sync enabled, a debug assertion is
triggered:

    DEBUG ASSERT: "isValid()" in function double mixxx::Bpm::value() const at src/track/bpm.h:53
    Aborted (core dumped)

The backtrace looks as follows:

    #0  0x00007f175c87234c in __pthread_kill_implementation () at /usr/lib/libc.so.6
    #1  0x00007f175c8254b8 in raise () at /usr/lib/libc.so.6
    #2  0x00007f175c80f534 in abort () at /usr/lib/libc.so.6
    #3  0x00007f175cf05ee4 in qt_assert(char const*, char const*, int) () at /usr/lib/libQt5Core.so.5
    #4  0x000055deb2e67e1c in mixxx::(anonymous namespace)::handleMessage(QtMsgType, QMessageLogContext const&, QString const&) (type=<optimized out>, context=<optimized out>, input=<optimized out>) at src/util/logging.cpp:355
    #5  0x00007f175cf47128 in  () at /usr/lib/libQt5Core.so.5
    #6  0x00007f175cf3fd8a in  () at /usr/lib/libQt5Core.so.5
    #7  0x00007f175cf06526 in QMessageLogger::critical(char const*, ...) const () at /usr/lib/libQt5Core.so.5
    #8  0x000055deb2e5c720 in mixxx_debug_assert(char const*, char const*, int, char const*) (assertion=assertion@entry=0x55deb39bd0db "isValid()", file=file@entry=0x55deb39bbf30 "src/track/bpm.h", line=line@entry=53, function=function@entry=0x55deb39bbf08 "double mixxx::Bpm::value() const") at gsrc/util/assert.h:9
    #9  0x000055deb2ee7e7e in mixxx_debug_assert_return_true(char const*, char const*, int, char const*) (function=0x55deb39bbf08 "double mixxx::Bpm::value() const", line=53, file=0x55deb39bbf30 "src/track/bpm.h", assertion=0x55deb39bd0db "isValid()") at gsrc/util/assert.h:18
    #10 mixxx::Bpm::value() const (this=<synthetic pointer>) at src/track/bpm.h:53
    #11 mixxx::operator*(mixxx::Bpm, double) (multiple=1, bpm=...) at src/track/bpm.h:160
    #12 SyncControl::setLocalBpm(mixxx::Bpm) (this=<optimized out>, localBpm=...) at src/engine/sync/synccontrol.cpp:567
    #13 0x000055deb34c7ba3 in EngineBuffer::postProcess(int) (this=0x55deb56eb060, iBufferSize=2048) at src/engine/enginebuffer.cpp:1318
    #14 0x000055deb3139023 in EngineMaster::processChannels(int) (this=0x55deb5449440, iBufferSize=<optimized out>) at src/engine/enginemaster.cpp:383
    #15 0x000055deb31394f7 in EngineMaster::process(int) (this=0x55deb5449440, iBufferSize=iBufferSize@entry=2048) at src/engine/enginemaster.cpp:410
    #16 0x000055deb2f91d0b in SoundManager::onDeviceOutputCallback(long) (this=<optimized out>, iFramesPerBuffer=iFramesPerBuffer@entry=1024) at src/soundio/soundmanager.cpp:596
    #17 0x000055deb32dd794 in SoundDevicePortAudio::callbackProcessClkRef(long, float*, float const*, PaStreamCallbackTimeInfo const*, unsigned long) (this=0x55deb553e6b0, framesPerBuffer=1024, out=<optimized out>, in=<optimized out>, timeInfo=<optimized out>, statusFlags=<optimized out>) at src/soundio/sounddeviceportaudio.cpp:965

This happens because `newLocalBpm` is invalid when `localBpm` is
invalid. Trying to do sync decks while no tempo information is available
does not make sense, so we only synchronize decks if the local BPM is
available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet