Fix application of best_ntree_limit to the entire list of estimators. Instead the limit is applied to per-class estimators split #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Instead the limit is applied to per-class estimators split
krinart
reviewed
Apr 3, 2019
m2cgen/assemblers/boosting.py
Outdated
| @@ -34,6 +36,10 @@ def assemble(self): | |||
| self.all_trees, self._base_score) | |||
|
|
|||
| def _assemble_single_output(self, trees, base_score=0): | |||
| if self._tree_limit is not None: | |||
| assert self._tree_limit > 0, "Unexpected tree limit" | |||
There was a problem hiding this comment.
I think __init__ method would be better place for this assert:
- No need to perform it every time this function runs
- It would raise an error right when we pass it, not when we use it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.