Added checks for external initialization to all model files so that they may be incorporated as headers for other firmware projects (e.g. tmk)) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
may be incorporated as headers for other firmware projects (e.g. tmk)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the board definitions in separate header files is very useful, as well as the functions for probe_column, etc... for example integrated with TMK firmware here:
https://github.com/bgould/costar_tmk_keyboard
Please let me know if you would like me to make any changes in order to get this incorporated. This seems like a better way than manually porting each of the controllers individually