-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create values-ko and translate english to korean #186
Conversation
add korean strings.xml
Dear @qylee, I would to inform you that we chosen to use the Crowdin platform to make, manage and maintain the localizations, in order to have a larger base of translators: this way also non-developers can translate and keep updated the strings of the application. We know that the importation of the strings is an extra work for the develop team but after some years, thanks to many volunteers, we have the possibility to include 10 localizations as confirmation that we chosen the right approach. I added the Korean language to the language list in case you would like to add your translated strings into the localization platform; we would be glad to add the Korean language to the next app update. As information: if you would like to be informed and discuss the new strings across the next updates, you can subscribe our GitHub translation channel (#16). |
Dear @GrazianoCapelli |
We noticed that you uploaded the translated strings into Crowdin: thanks for the great work. I agree with your choice to keep the international notation of the units of measurement (m, s, km/h, and so on). I have a general question about your translation: you often added a "." at the end of the strings also if it is not present on the original string; it is necessary in Korean language, or we can remove them when they are not present into the original string? |
It is a rule to put a period(.) in Korean sentences. However, there are cases where periods are used inconsistently. I fixed this in crowdin. |
We are close to release the update v3.1.7 of the app, and this could be a good occasion to include the Korean language. Anyway, feel free to contribute compatibly with your time and to your liking. I close this pull request. Thanks again for your contribution! |
add korean strings.xml