Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AlignmentGeometry in constructor #27

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

narumi147
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

defined: final AlignmentGeometry alignment
In constructor: Alignment? alignment,

Event in the comment of alignment field, it said can be AlignmentDirectional but the constructor not allowed.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@narumi147
Copy link
Contributor Author

@renefloor can you have a look? it's just a small change.

@martijn00 martijn00 merged commit 2636cf0 into Baseflow:develop Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants