Skip to content

Updated platform interface to have recording methods return XFile instances #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvanbeusekom merged 8 commits into from
Nov 13, 2020
Merged

Updated platform interface to have recording methods return XFile instances #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
613a92b
Updated platform interface to have recording methods return XFile ins…
BeMacized Nov 12, 2020
247d9c9
Update documentation and unit tests to match platform interface changes
BeMacized Nov 12, 2020
51c25b5
Make file input optional for recording methods in platform interface.…
BeMacized Nov 12, 2020
1b06322
Add missing full stop in docs.
BeMacized Nov 12, 2020
8e94057
Run dartfmt. Wrapped docs after max 80 cols. Added missing full stop.
BeMacized Nov 12, 2020
96bccd4
Updated platform interface
BeMacized Nov 13, 2020
79b58c8
Update packages/camera/camera_platform_interface/lib/src/platform_int…
BeMacized Nov 13, 2020
6c32fa9
Update packages/camera/camera_platform_interface/lib/src/platform_int…
BeMacized Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import 'dart:async';

import 'package:file_selector_platform_interface/file_selector_platform_interface.dart';
import 'package:flutter/widgets.dart';
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
import 'package:camera_platform_interface/src/method_channel/method_channel_camera.dart';
Expand Down Expand Up @@ -67,7 +68,7 @@ abstract class CameraPlatform extends PlatformInterface {
}

/// Captures an image and saves it to [path].

@mvanbeusekom mvanbeusekom Nov 12, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to update the documentation. Maybe something like:

Suggested change
/// Captures an image and saves it to [path].
/// Captures an image and returns it as a `XFile`. 

    

  
  




    


        

      
  
  

    
  
    
    

  

  

  



          

              

      








    


  





        

    


    


  		



    

    

    

  
      Future<void> takePicture(int cameraId, String path) {






    

    

    

  
      Future<XFile> takePicture(int cameraId) {






    

    

    

  
        throw UnimplementedError('takePicture() is not implemented.');






    

    

    

  
      }






    

    

    

  
    







      

    
        
          
        
        Expand All
    
    @@ -84,12 +85,12 @@ abstract class CameraPlatform extends PlatformInterface {
  


    

    

    

  
      /// The file is written on the flight as the video is being recorded.






    

    

    

  
      /// If a file already exists at the provided path an error will be thrown.






    

    

    

  
      /// The file can be read as soon as [stopVideoRecording] returns.






    

    

    

  
      Future<void> startVideoRecording(int cameraId, String path) {






    

    

    

  
      Future<void> startVideoRecording(int cameraId) {






    

    

    

  
        throw UnimplementedError('startVideoRecording() is not implemented.');






    

    

    

  
      }






    

    

    

  
    







    

    

    

  
      /// Stop the video recording.






    

    

    

  
      Future<void> stopVideoRecording(int cameraId) {






    

    

    

  
      Future<XFile> stopVideoRecording(int cameraId) {






    

    

    

  
        throw UnimplementedError('stopVideoRecording() is not implemented.');






    

    

    

  
      }






    

    

    

  
    







  

    
          
            
          
          Expand Down
    
    
  



                
              


          


    

  



      
  

    

      

        


          

            
            
          


          



          
            1 change: 1 addition & 0 deletions
          
          

        

  packages/camera/camera_platform_interface/pubspec.yaml

  
  
      
      
  





        
      


      

        











            


          

          

            
              

                
    

              

            
            
                            

                            


                              
   View file



                                    


                                  


                            


                            

                            

    Open in desktop



                
            
          

        

      

    



    

      

          

            




              
      
    
              

                
                  

                      Original file line number
                      Diff line number
                      Diff line change
                  

                
                
                      
      

    
          
            
          
          Expand Up
    
    @@ -10,6 +10,7 @@ dependencies:
  


    

    

    

  
        sdk: flutter






    

    

    

  
      meta: ^1.0.5






    

    

    

  
      plugin_platform_interface: ^1.0.1






    

    

    

  
      file_selector_platform_interface: ^1.0.0






    

    

    

  
    







    

    

    

  
    dev_dependencies:






    

    

    

  
      flutter_test:






  

    
          
            
          
          Expand Down