Skip to content

fix: web build #2164

Closed
rutikthakre wants to merge 19 commits intoBasedHardware:mainfrom
rutikthakre:web-support-1
Closed

fix: web build #2164
rutikthakre wants to merge 19 commits intoBasedHardware:mainfrom
rutikthakre:web-support-1

Conversation

@rutikthakre
Copy link
Contributor

@rutikthakre rutikthakre commented Apr 7, 2025

Changes

  • Updated Flutter web loading strategy
  • Package Version fixes
  • Added createUniversalSocket helper functions for web and io compatibility.
  • Implemented OmiFile file wrapper abstractions for web and IO compatibility. It uses Index db under the hood on the web and IO file on native platforms.
  • Removed all dart:io usage.
  • Added conditional execution for Analytics and Support packages that do not or partially support web.
  • Updated file uploading to utilize the http package, and modified other client code to also use http in place of IO.

fixes #2008
/claim #2008

@rutikthakre rutikthakre marked this pull request as ready for review April 8, 2025 09:11
Copy link
Collaborator

@skywinder skywinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments, the PR should be clean for merge in prod.

Please also add demo video and instructions how to run it for local tests.

…sistency

This commit replaces all direct `Platform` checks with the custom `PlatformUtil` utility to ensure consistent platform detection across the application. This change improves maintainability and reduces redundancy in platform-specific logic.
@rutikthakre
Copy link
Contributor Author

Please check comments, the PR should be clean for merge in prod.

Please also add demo video and instructions how to run it for local tests.

Sure, once I complete File handling then I will let you know and update the video demo as well

@rutikthakre
Copy link
Contributor Author

output.mp4

@skywinder Here is the working video of the PR
Here is how to test the PR

  1. Setup CORS proxy
npm i local-cors-proxy
lcp --proxyUrl=https://backend-dt5lrfkkoa-uc.a.run.app/ --credentials                                
  1. Change env
API_BASE_URL=http://localhost:8010/proxy/
  1. Run app
flutter run -d chrome

Note: Due to CORS, images do not fetch

@rutikthakre rutikthakre requested a review from skywinder April 13, 2025 21:04
Copy link
Collaborator

@skywinder skywinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, that’s a good next step. You made the change I asked for.

I left a few things to consider.

But there are quite a lot of other changes too, so we need to test it more and wait for a review from the people who work with the backend.

So bring attetion to @thinhx , since there is a lot of api modifications, which i'm not familiar yet.

@rutikthakre rutikthakre requested a review from skywinder April 16, 2025 11:23
@rutikthakre
Copy link
Contributor Author

@skywinder I have made the changes you asked for. please review

@rutikthakre rutikthakre requested a review from skywinder May 1, 2025 07:27
@beastoin
Copy link
Collaborator

beastoin commented May 9, 2025

@Rutik7066 man, sorry, we don’t have plans to support omi on the web anymore, as it’s been too long without a viable implementation.

if we ever plan to revisit web support, we’ll ping you - along with feedback to help you finalize your PR.

i'd like to send you coffee($) as a thank-you for your time here. please ping me on discord.

/ close

@beastoin beastoin closed this May 9, 2025
@rutikthakre
Copy link
Contributor Author

@beastoin Please check discord dm sir

@beastoin
Copy link
Collaborator

/tip $500 @Rutik7066

@algora-pbc
Copy link

algora-pbc bot commented May 10, 2025

Please visit Algora to complete your tip via Stripe.

@beastoin
Copy link
Collaborator

@Rutik7066 man, please send an email to team@basedhardware.com so the omi team can proceed with the next steps.

that’s all i can help with.

thank you.

@rutikthakre
Copy link
Contributor Author

@beastoin You need to complete tipping process via algora's dashboard

@beastoin
Copy link
Collaborator

@Rutik7066 man, please send an email to team@basedhardware.com so the omi team can proceed with the next steps.

that’s all i can help with.

thank you.

man, did you send the email ?

sorry, but i don’t have the algora account, so please just send an email to the team, request completing tipping via algora, and follow the instruction to claim your tips.

ah, please don’t spam my voice box - i need to focus on building things. thank you.

@Rutik7066

@rutikthakre
Copy link
Contributor Author

rutikthakre commented May 13, 2025

@Rutik7066 man, please send an email to team@basedhardware.com so the omi team can proceed with the next steps.

that’s all i can help with.

thank you.

man, did you send the email ?

sorry, but i don’t have the algora account, so please just send an email to the team, request completing tipping via algora, and follow the instruction to claim your tips.

ah, please don’t spam my voice box - i need to focus on building things. thank you.

@Rutik7066

Yes I did sent an email.

@mdmohsin7
Copy link
Member

The amount has been sent @Rutik7066

cc: @beastoin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make omi work in browser (for coding)

4 participants