Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load data from bonbast.com #1

Merged
merged 5 commits into from
Sep 2, 2022
Merged

load data from bonbast.com #1

merged 5 commits into from
Sep 2, 2022

Conversation

itsjoniur
Copy link
Collaborator

No description provided.

BaseMax
BaseMax approved these changes Sep 2, 2022
View reviewed changes
Copy link
Owner

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BaseMax BaseMax merged commit 8bcda75 into BaseMax:main Sep 2, 2022
BaseMax
BaseMax approved these changes Sep 2, 2022
View reviewed changes
Copy link
Owner

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BaseMax
Copy link
Owner

BaseMax commented Sep 2, 2022

It seems something is not correct on my Windows laptop. By the way, If this works. It's OK.

>go build .
go: downloading github.com/andelf/go-curl v0.0.0-20200630032108-fd49ff24ed97
# github.com/andelf/go-curl
..\go\pkg\mod\github.com\andelf\[email protected]\callback.go:8:10: fatal error: curl/curl.h: No such file or directory
    8 | #include <curl/curl.h>
      |          ^~~~~~~~~~~~~
compilation terminated.

@BaseMax
Copy link
Owner

BaseMax commented Sep 2, 2022

Posted: andelf/go-curl#82

@BaseMax
Copy link
Owner

BaseMax commented Sep 2, 2022

Good, now you can feel free and continue to complete the API routes and its cache mechanism.

@itsjoniur
Copy link
Collaborator Author

It seems something is not correct on my Windows laptop. By the way, If this works. It's OK.

>go build .
go: downloading github.com/andelf/go-curl v0.0.0-20200630032108-fd49ff24ed97
# github.com/andelf/go-curl
..\go\pkg\mod\github.com\andelf\[email protected]\callback.go:8:10: fatal error: curl/curl.h: No such file or directory
    8 | #include <curl/curl.h>
      |          ^~~~~~~~~~~~~
compilation terminated.

I think it's not working because CGO not supported in windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaseMax BaseMax BaseMax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsjoniur @BaseMax