test(6/N): update daytona/vercel sandbox cwd assertions to match builtin cd wrapper - #7
Merged
Merged
Conversation
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-argument-type |
3 |
First entries
run_agent.py:12539: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:6649: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:12542: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown, Unknown] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`
✅ Fixed issues (3):
| Rule | Count |
|---|---|
invalid-argument-type |
3 |
First entries
run_agent.py:12542: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown | str, Unknown | str | dict[str, str]] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`
run_agent.py:6649: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`
run_agent.py:12539: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`
Unchanged: 4073 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
Bartok9
pushed a commit
that referenced
this pull request
Aug 2, 2026
…ovider Cancelling the API-key prompt mid-wizard (Enter → 'Cancelled.') let the wizard continue through Terminal/Gateway/Tools and finish 'successfully' with no model configured — the user exits believing they're set up, then hits a broken chat. _print_setup_summary() (called by every setup path: full, quick, blank-slate, portal) now probes resolve_provider() and, when nothing is configured, prints an unmissable warning with the two one-line fixes (hermes model / hermes setup --portal). Consumer-onboarding audit finding #7 (sev 4), Aug 2026.
Bartok9
pushed a commit
that referenced
this pull request
Aug 3, 2026
… (re-review #7) - website/docs/user-guide/configuration.md (en) and the zh-Hans translation gain a 'Session Stall Watchdog' section: default 300, 0=disabled, notify-only semantics (never kills the turn — contrast gateway_timeout), one notification per stall episode, and the exact stall message text so it is greppable. - cli-config.yaml.example: the two in-agent compression timeout keys (compression.context_timeout_seconds / compression.context_total_ceiling_seconds) are shown as commented lines next to session_stall_timeout's example for discoverability.
Bartok9
pushed a commit
that referenced
this pull request
Aug 18, 2026
test(relay): document stream priming boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR 6/N in the test-suite-green effort. Targets 2 sandbox cwd-handling tests that share a single root cause.
Tests fixed (2)
tests/tools/test_daytona_environment.py::TestExecute::test_custom_cwd_in_command_wrappertests/tools/test_vercel_sandbox_environment.py::TestExecute::test_execute_runs_command_from_workspace_root_and_updates_cwdRoot cause
Both tests assert the literal substring
"cd /tmp"appears in the bash command string produced byBaseEnvironment._wrap_command(). The wrapper (tools/environments/base.py:409) actually emits the more robust form:builtin cd -- /tmpdoes not contain the substringcd /tmp(it'scd -- /tmp), so both assertions fail. The production code comments document this on purpose:builtinavoids any user-definedcdshell function override--prevents hyphen-prefixed directory names from being parsed ascdoptionsWhy this is a test-update, not a production-update
The wrapper's
builtin cd -- <dir>form is the intentional, more-correct behavior (present since the file was introduced in this history; no priorcd /tmpform ever existed). The wrapper is functionally equivalent and strictly more robust than a barecd. The test assertions are stale relative to the improved wrapper. Both assertions are updated to look forbuiltin cd -- /tmp, preserving each test's original intent (verify cwd is embedded in the command string via_wrap_command, not passed as a kwarg). No production code changed.Validation
(was 42 passed / 2 failed before this change)
Remaining-on-main
38 pre-existing failures noted on main before this effort. This PR removes 2 of them; the rest are out of scope for 6/N.
Note
Low Risk
Test-only comment and assertion updates; no runtime behavior changes.
Overview
Aligns Daytona and Vercel Sandbox execute tests with how
BaseEnvironment._wrap_command()embeds working directory changes: assertions now expectbuiltin cd -- /tmpin the bash-cscript instead of the substringcd /tmp.Comments in both tests document why (
builtinavoidscdoverrides;--protects hyphen-prefixed paths). No production code changes—only test expectations and documentation so CI matches the existing wrapper.Reviewed by Cursor Bugbot for commit ee33f69. Bugbot is set up for automated code reviews on this repo. Configure here.