-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Both the parsers in vast_utils.py
are broken.
#43
Comments
Ok, so there are a BUNCH of completely valid environment variable options that are broken.
It seems like the parser thingie here was kind of ad-hoc for a single use case, and it completely falls over if you do anything else. |
Here is a rewritten
It mainly fixes things by virtue of delegating all the shell command line parsing complexity to |
vast_utils.py
are broken.
Ok, so
It appears that the This query string works fine for the Edit: No, it's just broken period. |
This replaces the hand-rolled, broken shell argument parser with `shlex`, which has a full argument parser that handles all the weird corner cases of command line arguments. Note that `parse_query()` is still broken (see Barahlush#43).
I'm trying to figure out how the
parse_env()
function works. So far, it seems like it doesn't work for anything:returns:
The ASR_MODEL example string is literally from the docstring of the function. Nothing I do seems to ever cause it to return anything but an empty dict.
The text was updated successfully, but these errors were encountered: