Fix get_lamp_coordinates #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (ledIndex > LED_COUNT) return 0; | ||
|
|
||
| return round(std::fmod(ledIndex, stripXCoordinates)); | ||
| return cos16(ledIndex * 1.0/ledPerTurn * 2 * 3.14159265358 * ceil(ledPerTurn)); |
There was a problem hiding this comment.
use constants like PI (available with #include <Arduino.h>")
Put temporary computations in preprocessed :
static constexpr uint16_t temp = 1.0/ledPerTurn * 2 * 3.14159265358 * ceil(ledPerTurn);
return cos16(ledIndex * temp);
| if (ledIndex > LED_COUNT) return 0; | ||
| return (ledIndex * 1.0/LED_COUNT) * INT16_MAX; | ||
|
|
||
| } | ||
|
|
||
| uint16_t to_strip(uint16_t screenX, uint16_t screenY) { |
There was a problem hiding this comment.
now that the to_screen_x/y/z returns a signed int, this should also take in a signed int
| @@ -6,19 +6,21 @@ | |||
| #include "../ext/math8.h" | |||
| #include "constants.h" | |||
|
|
|||
| uint16_t to_screen_x(const uint16_t ledIndex) { | |||
| int16_t to_screen_x(const uint16_t ledIndex) { | |||
| if (ledIndex > LED_COUNT) return 0; | |||
There was a problem hiding this comment.
return LED_COUNT would be better
| uint16_t to_screen_z(const uint16_t ledIndex) { return 1; } | ||
| int16_t to_screen_z(const uint16_t ledIndex){ | ||
| if (ledIndex > LED_COUNT) return 0; | ||
| return (ledIndex * 1.0/LED_COUNT) * INT16_MAX; |
There was a problem hiding this comment.
static constexpr float temp = * 1.0/LED_COUNT) * INT16_MAX;
return ledIndex * temp;
BaptisteHudyma
force-pushed
the
indexable_strip_base
branch
from
8c8feee to
3264804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to issue #11
strip.get_lamp_coordinatesare now actually in Cartesian fomatTODO:
Change coordinates in Cartesian struct from int16 to half floats. Should fix those issues with mapping, but will slow down booting.