Remove some warnings

BaptisteHudyma · Aug 8, 2024 · 40049ae · 40049ae
1 parent ea09c14
commit 40049ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/system/colors/animations.cpp b/src/system/colors/animations.cpp
@@ -442,7 +442,8 @@ void candle(const palette_t& palette, LedStrip& strip) {
     const uint8_t minBrighness =
         currentStrenght - min(currentStrenght, targetPhaseAmplitude / 2);
     const uint8_t maxBrighness =
-        currentStrenght + min(255 - currentStrenght, targetPhaseAmplitude / 2);
+        currentStrenght +
+        min(UINT8_MAX - currentStrenght, targetPhaseAmplitude / 2);
 
     uint8_t brightness = random(minBrighness, maxBrighness);
     for (uint16_t i = 0; i < LED_COUNT; ++i) {

diff --git a/src/system/colors/wipes.cpp b/src/system/colors/wipes.cpp
@@ -60,7 +60,7 @@ bool dot_wipe_up(const Color& color, const uint32_t duration,
   const unsigned long delay =
       max(LOOP_UPDATE_PERIOD, duration / (float)LED_COUNT);
 
-  if (targetIndex >= 0 and targetIndex < LED_COUNT) {
+  if (targetIndex < LED_COUNT) {
     strip.fadeToBlackBy(fadeOut);
     // increment
     for (uint32_t increment = LED_COUNT / ceil(duration / delay); increment > 0;