Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate PSScriptAnalyzerSettings for Enhanced Code Quality #1269

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

mdaneri
Copy link
Contributor

@mdaneri mdaneri commented Mar 28, 2024

The purpose of this improvement request is to propose the inclusion of PSScriptAnalyzerSettings.psd1 in the Pode project. PowerShell Script Analyzer is a static code checker for PowerShell scripts and modules that encourages best practices and improves code quality. By integrating PSScriptAnalyzerSettings.psd1, we can define custom rules and configurations specific to Pode's needs, ensuring consistent code style, adherence to best practices, and early detection of potential issues.

Issue #1244

@Badgerati Badgerati added this to the 2.10.0 milestone Mar 29, 2024
PSScriptAnalyzerSettings.psd1 Outdated Show resolved Hide resolved
@Badgerati Badgerati linked an issue Mar 29, 2024 that may be closed by this pull request
@Badgerati
Copy link
Owner

I spotted in #1244 you reference updating the docs, is this something you want to do for the PR or good to merge?

@mdaneri
Copy link
Contributor Author

mdaneri commented Mar 29, 2024

I think it's good to go
renaming the internal functions is something for a future version

@Badgerati Badgerati merged commit 973af94 into Badgerati:develop Mar 29, 2024
11 checks passed
@mdaneri mdaneri deleted the #1244-PSScriptAnalyzerSettings branch March 29, 2024 23:23
@Badgerati Badgerati mentioned this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate PSScriptAnalyzerSettings for Enhanced Code Quality
2 participants