Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow onError function to late bound, and recalculated on each flush #262

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Allow onError function to late bound, and recalculated on each flush #262

merged 1 commit into from
Aug 25, 2017

Conversation

stefanpenner
Copy link
Collaborator

@stefanpenner stefanpenner commented Aug 25, 2017 •
edited
Loading

@stefanpenner stefanpenner mentioned this pull request Aug 25, 2017
Closed
rwjblue
rwjblue approved these changes Aug 25, 2017
View reviewed changes
Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me...

@stefanpenner stefanpenner merged commit c32ca81 into master Aug 25, 2017
@stefanpenner
Copy link
Collaborator Author

released as v1.2.0 🎉

@stefanpenner stefanpenner deleted the late-bound-onerror branch August 25, 2017 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@krisselden krisselden Awaiting requested review from krisselden

@lynchbomb lynchbomb Awaiting requested review from lynchbomb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @rwjblue