-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set --noProgress
implicitly if --quiet
was selected
#929
set --noProgress
implicitly if --quiet
was selected
#929
Conversation
1e8a08c
to
0264ad4
Compare
0264ad4
to
2c4a150
Compare
"bucket": | ||
self.api.get_bucket_by_name(args.bucketName), | ||
"cache_control": | ||
args.cache_control, | ||
"content_type": | ||
args.contentType, | ||
"custom_upload_timestamp": | ||
args.custom_upload_timestamp, | ||
"encryption": | ||
self._get_destination_sse_setting(args), | ||
"file_info": | ||
file_infos, | ||
"file_name": | ||
args.b2FileName, | ||
"file_retention": | ||
self._get_file_retention_setting(args), | ||
"legal_hold": | ||
self._get_legal_hold_setting(args), | ||
"local_file": | ||
args.localFilePath, | ||
"min_part_size": | ||
args.minPartSize, | ||
"progress_listener": | ||
make_progress_listener(args.localFilePath, args.noProgress or args.quiet), | ||
"sha1_sum": | ||
args.sha1, | ||
"threads": | ||
self._get_threads_from_args(args), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although this is interesting way how to improve readability, it will be reverted back when we'll eventually adopt Black.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change was done entirely by yapf;
AFAIK no plans for black adoption have been made
Fixes something we missed in #924
This may fix Mac integration tests errors we have been seeing as well.