set --noProgress implicitly if --quiet was selected
#929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurbanski-reef
force-pushed
the
truly_quiet
branch
from
1e8a08c
to
0264ad4
Compare
mjurbanski-reef
force-pushed
the
truly_quiet
branch
from
0264ad4
to
2c4a150
Compare
jsuchan-reef
reviewed
Oct 5, 2023
Comment on lines
+2841
to
+2868
| "bucket": | ||
| self.api.get_bucket_by_name(args.bucketName), | ||
| "cache_control": | ||
| args.cache_control, | ||
| "content_type": | ||
| args.contentType, | ||
| "custom_upload_timestamp": | ||
| args.custom_upload_timestamp, | ||
| "encryption": | ||
| self._get_destination_sse_setting(args), | ||
| "file_info": | ||
| file_infos, | ||
| "file_name": | ||
| args.b2FileName, | ||
| "file_retention": | ||
| self._get_file_retention_setting(args), | ||
| "legal_hold": | ||
| self._get_legal_hold_setting(args), | ||
| "local_file": | ||
| args.localFilePath, | ||
| "min_part_size": | ||
| args.minPartSize, | ||
| "progress_listener": | ||
| make_progress_listener(args.localFilePath, args.noProgress or args.quiet), | ||
| "sha1_sum": | ||
| args.sha1, | ||
| "threads": | ||
| self._get_threads_from_args(args), |
There was a problem hiding this comment.
although this is interesting way how to improve readability, it will be reverted back when we'll eventually adopt Black.
There was a problem hiding this comment.
this change was done entirely by yapf;
AFAIK no plans for black adoption have been made
jsuchan-reef
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes something we missed in #924
This may fix Mac integration tests errors we have been seeing as well.