Add ability to upload from an unbound source such as standard input or a named pipe #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "sha1_sum": args.sha1, | ||
| } | ||
|
|
||
| def execute_operation(self, **kwargs) -> 'b2sdk.file_version.FileVersion': |
There was a problem hiding this comment.
why this and not abc?
| ) | ||
| return file_id | ||
|
|
||
| class NotAnInputStream(Exception): |
There was a problem hiding this comment.
I don't think I've seen his pattern in this project before, any reason for not declaring this exception at module level?
There was a problem hiding this comment.
because the only function rising it is a class method; i.e. if this function is removed, exception should be removed as well
We are talking about ~4k long file, which is why namespacing is especially important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It maybe best to use a squash merge here since there are so many commits here.