Inspector v2: Update Playground webpack config for sharedUiComponents #17274
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17274/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17274/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17274/merge#BCU1XR#0 |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17274/merge/ |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
WebGL2 visualization test reporter: |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17274/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
3 participants
I noticed that Color and Vector/Quaternion related properties were not displaying correctly in Inspector v2 specifically in Playground. After a little investigation, I realized that imports from core, loaders, etc. were being correctly externalized to BABYLON.* for any code directly in inspector-v2, but not for sharedUiComponents, which means specifically for our shared controls, the Playground app bundle itself was basically getting extra copies of Color*/Vector*/Quaternion classes and the
instanceofchecks were failing (because they were two different classes with the same name/content). This change updates Playground's webpack config to externalize any core, loaders, etc. imports to use BABYLON.*, which fixes the problem.