Skip to content

Conversation

ryantrem
Copy link
Member

@ryantrem ryantrem commented Oct 10, 2025

This PR is mostly adding properties for SpriteManager, and some missing ones for Sprite.

  • Consolidate different Sprite related property components into one file (following the same pattern we have for other entity properties).
  • Add properties for Sprite's cellIndex, invertU, invertY, isPickable, and useAlphaForPicking.
  • Add a new file for SpriteManager properties (we didn't have it at all before), and add most of the properties (save/load and snippet still needed).

A few other changes included in this PR

  • Add missing outlineWidth property for AbstractMesh render outline.
  • Add missing useEffect to make sure external color value changes (outside of the color picker) are reflected in the color picker.
  • Hide the scroll bar while our Collapse is expanding/collapsing.
image image

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17273/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17273/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17273/merge/?snapshot=refs/pull/17273/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17273/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17273/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17273/merge/?snapshot=refs/pull/17273/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 10, 2025

@deltakosh deltakosh merged commit d0e4153 into BabylonJS:master Oct 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants