Initial implementation for Area Lights #16078
Conversation
…into sergio/area-light
…of Specular power
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
packages/dev/core/src/Shaders/ShadersInclude/lightsFragmentFunctions.fx
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Shaders/ShadersInclude/pbrDirectLightingSetupFunctions.fx
Show resolved
Hide resolved
packages/dev/inspector/src/components/actionTabs/tabs/propertyGridTabComponent.tsx
Outdated
Show resolved
Hide resolved
…GridTabComponent.tsx Co-authored-by: Popov72 <[email protected]>
Co-authored-by: Popov72 <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
|
Visualization tests for WebGPU (Experimental) |
|
WebGL2 visualization test reporter: |
| ltc1Texture: BaseTexture; | ||
|
|
||
| /** | ||
| * Linearly trasnformed cossine texture Fresnel Approximation. | ||
| * Linearly transformed cosine texture Fresnel Approximation. | ||
| */ | ||
| ltc2Texture: BaseTexture; | ||
|
|
||
| /** | ||
| * Promise to wait for Area Lights are ready. | ||
| */ | ||
| whenAreaLightsReady: Promise<void>; |
There was a problem hiding this comment.
This is not a great pattern. It's possible for someone to get an undefined ltc texture with the contract. Consider returning the ltc textures in the Promise result and rename function to getTexturesAsync.
| const _ltc1 = new Uint16Array(64 * 64 * 4); | ||
| const _ltc2 = new Uint16Array(64 * 64 * 4); | ||
|
|
||
| const ltcPath = Tools.GetBabylonScriptURL("https://assets.babylonjs.com/areaLights/areaLightsLTC.bin", true); |
There was a problem hiding this comment.
I think we should still support something through the script base url if we can ? this is the centralized way for our users to prevent external call.
| } | ||
|
|
||
| public transferToNodeMaterialEffect(effect: Effect, lightDataUniformName: string) { | ||
| // TO DO: Implement this to add support for NME. |
| uniform sampler2D areaLightsLTC2Sampler; | ||
|
|
||
| lightingInfo computeAreaLighting(sampler2D ltc1, sampler2D ltc2, vec3 viewDirectionW, vec3 vNormal, vec3 vPosition, vec4 lightData, vec3 halfWidth, vec3 halfHeight, vec3 diffuseColor, vec3 specularColor, float roughness ) |
There was a problem hiding this comment.
Can we add the reference to the paper we used just before the function ?
There was a problem hiding this comment.
it also looks really similar to computeAreaPreLightingInfo ? nothing we should factorize ? the rest is splitted cause pbr and standard do not do the same.
| // http://blog.selfshadow.com/publications/s2016-advances/s2016_ltc_fresnel.pdf | ||
| vec3 fresnel = ( specularColor * t2.x + ( vec3( 1.0 ) - specularColor ) * t2.y ); | ||
| result.areaLightSpecular = specularColor * fresnel * LTCEvaluate( normal, viewDir, position, mInv, rectCoords ); |
There was a problem hiding this comment.
I guess we should not do the mul by specularColor to be consistent with the diffuse part
Overview
This PR provides a first implementation for rectangular area lights. The implementation is based on reference repo https://github.com/selfshadow/ltc_code/ and uses the Linearly Transformed Cosines technique described by Eric Heitz, Jonathan Dupuy, Stephen Hill and David Neubelt`s paper in 2016 . This PR only supports single color rectangular area lights with texture support been introduced in a latter PR. This PR also does not support shadows for the RectAreaLight.
API
Besides the usual diffuse and specular colors the area light is defined by a position, a width and a height. Setting a rotation is possible by assigning a transform node as a parent for the light.
By default shaders will use LTC data stored in the Babylon.js CDN. However, users can assign their own
IAreaLightLTCProvidertoscene.areaLightLTCProviderand use their own LTC textures.