Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations goToFrame: Fix breaking change introduced in #15126 #15818

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Nov 14, 2024

See https://forum.babylonjs.com/t/animation-blending-and-key-interpolation-bug-in-new-cdn/54729/4.

My change in #15126 was a breaking change, because when the weight isn't -1, the animation is considered additive, and this can break if there isn't at least one animation that isn't additive.

I needed this change for Teams Avatar, so I made a change so that the old behavior is the default, but I added a flag so that I could use the animation weight on demand.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@RaananW
Copy link
Member

RaananW commented Nov 14, 2024

Does this restore the previous behavior?

@RaananW RaananW merged commit 7b7f4d8 into BabylonJS:master Nov 14, 2024
12 checks passed
@Popov72
Copy link
Contributor Author

Popov72 commented Nov 14, 2024

Does this restore the previous behavior?

Yes, the new behavior is now under a flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants