Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] glTF interactivity and flow graph update (For snapshot) #15810

Draft
wants to merge 157 commits into
base: master
Choose a base branch
from

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Nov 13, 2024

I open this PR just to update the snapshot.
No reviews needed for the time being

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 17, 2024

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 17, 2024

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/?snapshot=refs/pull/15810/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@hybridherbst
Copy link

Here's a couple more files that aren't working in this PR's Babylon Sandbox at the moment:

@RaananW
Copy link
Member Author

RaananW commented Dec 19, 2024

The reason this doesn't work is the math/mix node. According to the specs, c should be a floatN (which should be the same as a and b), but the value you provide is a float. Thus, position setting fails. One could argue that for math/mix the c value could be a float (applying to all dimensions of the floatN), but this is not the case currently.

This is specified here - https://github.com/KhronosGroup/glTF/blob/interactivity/extensions/2.0/Khronos/KHR_interactivity/Specification.adoc#361-math-nodes

Second one should be fine now.

@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Dec 20, 2024
@hybridherbst
Copy link

Happy new year!

Here's a file that currently fails, according to the console because math/rad is missing:
20250701-CircleMath (1).glb.zip

The black dot should rotate clockwise.

@RaananW
Copy link
Member Author

RaananW commented Jan 8, 2025

Happy new year!

Here's a file that currently fails, according to the console because math/rad is missing: 20250701-CircleMath (1).glb.zip

The black dot should rotate clockwise.

It's weird that it is not attached, it is already implemented in the flow graph. I'll take care of that.

@RaananW
Copy link
Member Author

RaananW commented Jan 9, 2025

Current change fixes that. I am waiting for the specs update to do the mapping again and be sure I have all nodes attached, but if you have any other demos/samples to test - feel free to send'em over :-)

@BabylonJS BabylonJS deleted a comment from bjsplat Jan 9, 2025
@BabylonJS BabylonJS deleted a comment from bjsplat Jan 9, 2025
@hybridherbst
Copy link

Will do :)
I spent some time today making a math nodes test file for float types, currently that doesn't load:
20250109-MathTests.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants