-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] glTF interactivity and flow graph update (For snapshot) #15810
base: master
Are you sure you want to change the base?
Conversation
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/15810/merge/ |
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15810/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
Here's a couple more files that aren't working in this PR's Babylon Sandbox at the moment: |
The reason this doesn't work is the math/mix node. According to the specs, c should be a floatN (which should be the same as a and b), but the value you provide is a float. Thus, position setting fails. One could argue that for math/mix the c value could be a float (applying to all dimensions of the floatN), but this is not the case currently. This is specified here - https://github.com/KhronosGroup/glTF/blob/interactivity/extensions/2.0/Khronos/KHR_interactivity/Specification.adoc#361-math-nodes Second one should be fine now. |
Happy new year! Here's a file that currently fails, according to the console because The black dot should rotate clockwise. |
It's weird that it is not attached, it is already implemented in the flow graph. I'll take care of that. |
Current change fixes that. I am waiting for the specs update to do the mapping again and be sure I have all nodes attached, but if you have any other demos/samples to test - feel free to send'em over :-) |
Will do :) |
I open this PR just to update the snapshot.
No reviews needed for the time being