Skip to content

Fix dll installation on Windows#350

Merged
lotem merged 1 commit intoBYVoid:masterfrom
myd7349:fix-dll-install
Oct 8, 2019
Merged

Fix dll installation on Windows#350
lotem merged 1 commit intoBYVoid:masterfrom
myd7349:fix-dll-install

Conversation

@myd7349
Copy link
Contributor

@myd7349 myd7349 commented Oct 7, 2019

According the CMake docs(https://cmake.org/cmake/help/latest/command/install.html):

Executables are treated as RUNTIME objects, except those marked with the MACOSX_BUNDLE property on macOS (see BUNDLE below.) For DLL platforms (all Windows-based systems including Cygwin), the DLL part of a shared library is treated as a RUNTIME target.

Here, I use bin instead of CMAKE_INSTALL_BINDIR, which is defined in GNUInstallDirs.cmake.

@lotem lotem merged commit 05a2b5c into BYVoid:master Oct 8, 2019
@lotem
Copy link
Collaborator

lotem commented Oct 8, 2019

Thanks for the pull request.
Merged.

@myd7349 myd7349 deleted the fix-dll-install branch October 8, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants