Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test dependencies #403

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Add test dependencies #403

merged 1 commit into from
Mar 25, 2020

Conversation

daniekpo
Copy link
Contributor

Add test dependencies for open-cv for tests that depend on open-cv to run. We were previously getting an error about a missing dependency. Closes #347

@daniekpo daniekpo self-assigned this Mar 23, 2020
vinhowe
vinhowe approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@vinhowe vinhowe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dexterity tests are failing instead of skipping even with db23272 (#405), and there's an assertion failure with test_joint_rotation_sensor. I'm able to reproduce both of these failures on my host computer on latest develop, so it looks like they're unrelated to this PR. All other tests pass.

@daniekpo daniekpo merged commit e0e7199 into develop Mar 25, 2020
@daniekpo daniekpo deleted the docker_test branch March 25, 2020 01:33
@vinhowe vinhowe linked an issue Mar 25, 2020 that may be closed by this pull request
Improve Docker Experience #347
Closed
5 tasks
@vinhowe vinhowe removed a link to an issue Mar 25, 2020
Improve Docker Experience #347
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaydenmilne jaydenmilne jaydenmilne approved these changes

@vinhowe vinhowe vinhowe approved these changes

@MaxRobinsonTheGreat MaxRobinsonTheGreat Awaiting requested review from MaxRobinsonTheGreat

Assignees

@daniekpo daniekpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniekpo @jaydenmilne @vinhowe