Bugfix: final snapshot iter number is off by one #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapshot being off by one
jeffdonahue
force-pushed
the
final-snapshot-off-by-one
branch
from
22da1df
to
4a4118f
Compare
weiliu89
added a commit
to weiliu89/caffe
that referenced
this pull request
Apr 14, 2015
|
Looks good, this logic is cleaner and more correct. Thanks @jeffdonahue! |
longjon
added a commit
that referenced
this pull request
May 14, 2015
Bugfix: final snapshot iter number is off by one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1228 the final snapshot has saved as
*_iter_N.{solverstate,caffemodel}whereN = max_iter + 1. This fixes that. @longjon