make pytest fails unless WITH_PYTHON_LAYER is set

[lukeyeager]

I just noticed to day that there is a pytest path in the Makefile. Looks like it was added here: #1473. When I run make pytest, I get this error:

layer_factory.hpp:77] Check failed: registry.count(type) == 1 (0 vs. 1) Unknown layer type: Python

...

*** Check failure stack trace: ***
Aborted (core dumped)
make: *** [pytest] Error 134

I've got a pretty standard installation here. I assume this is just not something most people check, so it doesn't get updated. Is this really tested and passing in travis?

P.S. If caffe would just exit with an error code instead of coredumping, then the rest of the tests could run and I could get an actual test report. This is an issue across the board with the python interface.

[shelhamer]

This is a known issue with pytest: if you compile pycaffe without the Python layer option WITH_PYTHON_LAYER then this test fails. @longjon and I haven't had a chance to put in a workaround that determines whether or not this layer is included and skip the test if not.

Is this really tested and passing in travis?

Yeah it is, and @longjon and I do make pytest in our work. The travis configuration includes Python layer so this passes.

Thanks for reporting since this issue will make the situation with this test clear.

p.s. Travis questions can be answered by looking at https://github.com/BVLC/caffe/blob/master/.travis.yml and https://github.com/BVLC/caffe/tree/master/scripts/travis

[lukeyeager]

Oh ok, I didn't know about the WITH_PYTHON_LAYER option. Thanks for the info.

[shelhamer]

(Re-opening for visibility until the test is adapted to when this condition is off.)